Improve error reporting #48
No reviewers
Labels
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: karolyi/py3-validate-email#48
Loading…
Reference in New Issue
No description provided.
Delete Branch "master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
well
@karolyi @manojr2k I tried with some domains, but I think it would be good if you could do some more checks with this code before doing a release.
I see a problem with this PR. Before, if there was a 4XX response code, the messages were added to the result. Now, that entire part is removed, and the 4XX response with the message completely suppressed. That's a breaking change. Could you add that part back?
Thank you for the hint about the travis error, I fixed that.
To me it looks like in the current code, the 4XX response codes returned from
_smtp_converse
are indeed added to theerror_messages
list in_check_one_mx
, but at the same time the latter function returnsTrue
, so the error message list is not used. That's why I removed that part of the code: at first sight it looks as if the 4XX response codes were collected, but only when looking closer you see that they are discarded again later, so it's quite confusing.Yeah, I see what you mean now. I think it would be a useful information to keep it somehow for the user, but with the current structure it's not really available.
I'll merge this now and we'll take care of the collecting of ambiguous messages later, when necessary. Thanks!