karolyi
/
py3-validate-email
3
3
Fork 4
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Add no_smtp argument that allows us to validate only mx records witho… #49

Merged
sergeyshevch merged 3 commits from feature/add-no_smtp_argument into master 2021-02-11 16:54:09 +01:00
Conversation 8 Commits 3 Files Changed 4 +19 -4
sergeyshevch commented 2021-02-11 14:46:46 +01:00 (Migrated from github.com)
Copy Link

Hi!

For our proposes, we need to validate only MX records without SMTP requests.

So in some places (registration, forgot password), we will use full validation with SMTP requests.
In other places, we will use validation without SMTP requests.

I have added tests that validate that my changes work correctly. Also, this argument was added at the end of the arguments list with default, to provide backward compatibility.

Hi! For our proposes, we need to validate only MX records without SMTP requests. So in some places (registration, forgot password), we will use full validation with SMTP requests. In other places, we will use validation without SMTP requests. I have added tests that validate that my changes work correctly. Also, this argument was added at the end of the arguments list with default, to provide backward compatibility.
karolyi commented 2021-02-11 14:55:23 +01:00 (Migrated from github.com)
Copy Link

hey,

the check_mx parameter stands exactly for this purpose. did you not discover it?

hey, the `check_mx` parameter stands exactly for this purpose. did you not discover it?
sergeyshevch commented 2021-02-11 14:59:58 +01:00 (Migrated from github.com)
Copy Link

Yes we need to check_mx records but not send SMTP responses

Yes we need to check_mx records but not send SMTP responses
karolyi commented 2021-02-11 15:02:41 +01:00 (Migrated from github.com)
Copy Link

Yeah, I see now.

Could you also add the parameter in the README please?

Yeah, I see now. Could you also add the parameter in the README please?
sergeyshevch commented 2021-02-11 15:04:09 +01:00 (Migrated from github.com)
Copy Link

Ok, I will do it today

Ok, I will do it today
sergeyshevch commented 2021-02-11 15:49:29 +01:00 (Migrated from github.com)
Copy Link

Done. @karolyi Can you make a release after merging it?
I will use the package directly from PyPI instead of my fork repo.

Done. @karolyi Can you make a release after merging it? I will use the package directly from PyPI instead of my fork repo.
karolyi commented 2021-02-11 16:00:35 +01:00 (Migrated from github.com)
Copy Link

If the travis build with the test checks out, I'll make a release.

If the travis build with the test checks out, I'll make a release.
👍 1
sergeyshevch commented 2021-02-11 16:53:22 +01:00 (Migrated from github.com)
Copy Link

@karolyi Some tests are failing now but were passed correctly in 8f08c01
Can you look on it?

@karolyi Some tests are failing now but were passed correctly in `8f08c01` Can you look on it?
karolyi commented 2021-02-11 16:54:02 +01:00 (Migrated from github.com)
Copy Link

the tests failing is not on you, I'll have to fix it, update and release coming soon.

the tests failing is not on you, I'll have to fix it, update and release coming soon.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
stale

   
wontfix

This will not be worked on

No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
stale
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: karolyi/py3-validate-email#49
No description provided.
Delete Branch "feature/add-no_smtp_argument"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?