karolyi
/
py3-validate-email
2
1
Fork 3
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Labels Milestones

Add no_smtp argument that allows us to validate only mx records witho… #49

Merged
sergeyshevch merged 3 commits from feature/add-no_smtp_argument into master 2 years ago
Conversation 8 Commits 3 Files Changed 4
sergeyshevch commented 2 years ago (Migrated from github.com)

Hi!

For our proposes, we need to validate only MX records without SMTP requests.

So in some places (registration, forgot password), we will use full validation with SMTP requests.
In other places, we will use validation without SMTP requests.

I have added tests that validate that my changes work correctly. Also, this argument was added at the end of the arguments list with default, to provide backward compatibility.

Hi! For our proposes, we need to validate only MX records without SMTP requests. So in some places (registration, forgot password), we will use full validation with SMTP requests. In other places, we will use validation without SMTP requests. I have added tests that validate that my changes work correctly. Also, this argument was added at the end of the arguments list with default, to provide backward compatibility.
karolyi commented 2 years ago (Migrated from github.com)

hey,

the check_mx parameter stands exactly for this purpose. did you not discover it?

hey, the `check_mx` parameter stands exactly for this purpose. did you not discover it?
sergeyshevch commented 2 years ago (Migrated from github.com)

Yes we need to check_mx records but not send SMTP responses

Yes we need to check_mx records but not send SMTP responses
karolyi commented 2 years ago (Migrated from github.com)

Yeah, I see now.

Could you also add the parameter in the README please?

Yeah, I see now. Could you also add the parameter in the README please?
sergeyshevch commented 2 years ago (Migrated from github.com)

Ok, I will do it today

Ok, I will do it today
sergeyshevch commented 2 years ago (Migrated from github.com)

Done. @karolyi Can you make a release after merging it?
I will use the package directly from PyPI instead of my fork repo.

Done. @karolyi Can you make a release after merging it? I will use the package directly from PyPI instead of my fork repo.
karolyi commented 2 years ago (Migrated from github.com)

If the travis build with the test checks out, I'll make a release.

If the travis build with the test checks out, I'll make a release.
👍 1
sergeyshevch commented 2 years ago (Migrated from github.com)

@karolyi Some tests are failing now but were passed correctly in 8f08c01
Can you look on it?

@karolyi Some tests are failing now but were passed correctly in `8f08c01` Can you look on it?
karolyi commented 2 years ago (Migrated from github.com)

the tests failing is not on you, I'll have to fix it, update and release coming soon.

the tests failing is not on you, I'll have to fix it, update and release coming soon.
👍 1
The pull request has been merged as 81f5769ac8.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b feature/add-no_smtp_argument master
git pull origin feature/add-no_smtp_argument

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff feature/add-no_smtp_argument
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
bug

Something isn't working   
duplicate

This issue or pull request already exists   
enhancement

New feature or request   
good first issue

Good for newcomers   
help wanted

Extra attention is needed   
invalid

This doesn't seem right   
question

Further information is requested   
stale
   
wontfix

This will not be worked on
No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
stale
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: karolyi/py3-validate-email#49
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feature/add-no_smtp_argument'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes