karolyi
/
py3-validate-email
2
1
Fork 3
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Labels Milestones

Next step towards 1.0.0 #63

Merged
reinhard-mueller merged 6 commits from master into version-1.0.0 2 years ago
Conversation 2 Commits 6 Files Changed 12
reinhard-mueller commented 2 years ago (Migrated from github.com)

Comments welcome!

Comments welcome!
reinhard-mueller commented 2 years ago (Migrated from github.com)

BTW, I will add more unittests for smtp_check to this PR soon, but you're still welcome to comment on what's already here.

BTW, I will add more unittests for `smtp_check` to this PR soon, but you're still welcome to comment on what's already here.
karolyi (Migrated from github.com) reviewed 2 years ago
FAQ.md
@ -14,3 +21,4 @@
we talk to seemingly accepts the email address.
## Everything gets rejected:
karolyi (Migrated from github.com) commented 2 years ago

Is this really the case with MS servers? So far I've seen outlook servers (if you meant those) rejecting the invalid emails properly.

Is this really the case with MS servers? So far I've seen outlook servers (if you meant those) rejecting the invalid emails properly.
karolyi (Migrated from github.com) reviewed 2 years ago
FAQ.md
karolyi (Migrated from github.com) commented 2 years ago

"dynamic range" is called an IP pool

"dynamic range" is called an IP pool
karolyi (Migrated from github.com) reviewed 2 years ago
FAQ.md
karolyi (Migrated from github.com) commented 2 years ago

... servers for many email domains (depending on their configuration) will reject connections ...

... servers for many email domains (depending on their configuration) will reject connections ...
karolyi (Migrated from github.com) reviewed 2 years ago
validate_email/validate_email.py
karolyi (Migrated from github.com) commented 2 years ago

if not check_dns and not check_smtp: is preferred, as it's more pythonic :)

`if not check_dns and not check_smtp:` is preferred, as it's more pythonic :)
karolyi (Migrated from github.com) reviewed 2 years ago
validate_email/smtp_check.py
karolyi (Migrated from github.com) commented 2 years ago

This can look like

def smtp_check(
    email_address: EmailAddress, mx_records: List[str],
    timeout: float = 10, helo_host: Optional[str] = None,
    from_address: Optional[EmailAddress] = None, debug: bool = False
) -> bool:

(autopep8 make these changes)

This can look like ```python def smtp_check( email_address: EmailAddress, mx_records: List[str], timeout: float = 10, helo_host: Optional[str] = None, from_address: Optional[EmailAddress] = None, debug: bool = False ) -> bool: ``` (autopep8 make these changes)
karolyi (Migrated from github.com) reviewed 2 years ago
karolyi (Migrated from github.com) left a comment

There was a couple comments I made, but aside from those, I'm very satisfied with what you did here.

You did a nice documentation job there, clever job done with the tests. Let's iron out the changes I mentioned here and the dependency questions, and then I think we're ready for the major release.

There was a couple comments I made, but aside from those, I'm very satisfied with what you did here. You did a nice documentation job there, clever job done with the tests. Let's iron out the changes I mentioned here and the dependency questions, and then I think we're ready for the major release.
reinhard-mueller (Migrated from github.com) reviewed 2 years ago
FAQ.md
@ -14,3 +21,4 @@
we talk to seemingly accepts the email address.
## Everything gets rejected:
reinhard-mueller (Migrated from github.com) commented 2 years ago

I have tested various domains where the MX is .mail.protection.outlook.com; some of them reject invalid emails properly and some don't. If you want I can send you some examples in private email, you can find my email address [here[(https://wiki.fsfe.org/Supporters/reinhard).

I have tested various domains where the MX is <domainname>.mail.protection.outlook.com; some of them reject invalid emails properly and some don't. If you want I can send you some examples in private email, you can find my email address [here[(https://wiki.fsfe.org/Supporters/reinhard).
karolyi commented 2 years ago (Migrated from github.com)

This was a great contribution, thank you!

I'll change the idna dependency and make a 1.0.0 release soon.

This was a great contribution, thank you! I'll change the idna dependency and make a 1.0.0 release soon.
The pull request has been merged as ed7e0e96d9.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b master version-1.0.0
git pull origin master

Step 2:

Merge the changes and update on Gitea.
git checkout version-1.0.0
git merge --no-ff master
git push origin version-1.0.0
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
bug

Something isn't working   
duplicate

This issue or pull request already exists   
enhancement

New feature or request   
good first issue

Good for newcomers   
help wanted

Extra attention is needed   
invalid

This doesn't seem right   
question

Further information is requested   
stale
   
wontfix

This will not be worked on
No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
stale
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: karolyi/py3-validate-email#63
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes